Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

home-assistant: Add support for Yoto custom component #368833

Merged
merged 2 commits into from
Jan 3, 2025

Conversation

seberm
Copy link
Contributor

@seberm seberm commented Dec 28, 2024

This PR adds support for Yoto Home-Assistant custom component:

Things done

  • Added python3 package yoto-api which is needed for yoto-ha custom component.
  • Added and tested the custom Yoto component in my local HA instance.

Tested in my local HA configuration in the following way:

customComponents = with pkgs-unstable; [
  (callPackage ../hass/custom-components/yoto_ha/package.nix {
    yoto-api = (python3Packages.callPackage ../hass/pkgs/yoto-api.nix {});
  })
];
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nix-owners nix-owners bot requested review from mweinelt and natsukium December 28, 2024 15:03
@seberm seberm added the 0.kind: packaging request Request for a new package to be added label Dec 28, 2024
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes labels Dec 28, 2024
@seberm seberm force-pushed the feature/hass-yoto-support branch from df4a56b to 2cf4e75 Compare December 31, 2024 15:35
@seberm seberm requested a review from mweinelt December 31, 2024 15:38
@seberm seberm force-pushed the feature/hass-yoto-support branch from 2cf4e75 to eb75913 Compare January 2, 2025 14:29
@mweinelt mweinelt merged commit 32a0af8 into NixOS:master Jan 3, 2025
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: packaging request Request for a new package to be added 6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants