fvm: init at 3.2.1 #368392
fvm: init at 3.2.1 #368392
Conversation
github-actions
bot
added
8.has: maintainer-list (update)
ofborg
bot
added
8.has: package (new)
There was a problem hiding this comment.
Please follow CONTRIBUTING guidelines for commit messages.
maintainers: add MH0386
fvm: init at 3.2.1
| cmake | ||
| ]; | ||
|
|
||
| shellHook = '' |
There was a problem hiding this comment.
I think you want to set env.PKG_CONFIG_PATH and env.LD_LIBRARY_PATH instead. Or if you really need to keep the current environment, use preBuild or something else.
There was a problem hiding this comment.
It is very likely that once you add gtk3 to buildInputs, this becomes unnecessary.
| passthru.updateScript = nix-update-script { }; | ||
|
|
||
| postInstall = '' | ||
| export HOME=$TMPDIR |
There was a problem hiding this comment.
| export HOME=$TMPDIR | |
| export HOME=$(mktemp -d) |
| export PKG_CONFIG_PATH=${gtk3.dev}/lib/pkgconfig | ||
| export LD_LIBRARY_PATH=${gtk3.out}/lib:$LD_LIBRARY_PATH |
There was a problem hiding this comment.
| export PKG_CONFIG_PATH=${gtk3.dev}/lib/pkgconfig | |
| export LD_LIBRARY_PATH=${gtk3.out}/lib:$LD_LIBRARY_PATH | |
| export PKG_CONFIG_PATH=${lib.getDev gtk3}/lib/pkgconfig | |
| export LD_LIBRARY_PATH=${gtk3}/lib:$LD_LIBRARY_PATH |
There was a problem hiding this comment.
This looks really strange though, are you sure the build doesn't work without this being set?
| nativeBuildInputs = [ | ||
| clang | ||
| pkg-config | ||
| gtk3 | ||
| cmake | ||
| ]; |
There was a problem hiding this comment.
| nativeBuildInputs = [ | |
| clang | |
| pkg-config | |
| gtk3 | |
| cmake | |
| ]; | |
| nativeBuildInputs = [ | |
| cmake | |
| pkg-config | |
| ]; | |
| buildInputs = [ gtk3 ]; |
If you really need clang instead of gcc, please override stdenv for buildDartApplication:
buildDartApplication.override { stdenv = clangStdenv; } { ... }
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.