Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

atf: 0.21-unstable-2021-09-01 -> 0.22-unstable-2024-12-26 #368294

Open
wants to merge 1 commit into
base: staging
Choose a base branch
from

Conversation

Bot-wxt1221
Copy link
Member

@Bot-wxt1221 Bot-wxt1221 commented Dec 26, 2024

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/5020

pkgs/by-name/at/atf/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/at/atf/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/at/atf/package.nix Show resolved Hide resolved
@Bot-wxt1221 Bot-wxt1221 force-pushed the atf branch 2 times, most recently from 59faddb to 51de25e Compare December 29, 2024 04:09
@Bot-wxt1221 Bot-wxt1221 added the backport release-24.11 Backport PR automatically label Dec 29, 2024
@Bot-wxt1221 Bot-wxt1221 changed the title atf: 0.21-unstable-2021-09-01 -> 0.22 atf: 0.21-unstable-2021-09-01 -> 0.22-unstable-2024-12-26 Dec 29, 2024
@Bot-wxt1221 Bot-wxt1221 requested a review from ck3d December 29, 2024 04:36
Copy link
Contributor

@reckenrode reckenrode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include a link to the release notes per the contributing guidelines. Also, please revert to 0.22 with patches to fix the failing test. The reason why this package used an unstable commit before is because a release had not been made in a while, and that is what FreeBSD was using for their build. In general, https://dont-ship.it.

From what I can tell, FreeBSD appears to be shipping ATF 0.22 with the following commit cherry-picked to fix breakage in the test suite: freebsd/atf@b42c986. If that fixes the test failure here, I’d recommend using 0.22 with this patch.

@Bot-wxt1221 Bot-wxt1221 force-pushed the atf branch 2 times, most recently from b61dbaf to 1d114ff Compare December 30, 2024 04:49
@Bot-wxt1221
Copy link
Member Author

@reckenrode Done.

@Bot-wxt1221
Copy link
Member Author

@ofborg build atf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants