-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
atf: 0.21-unstable-2021-09-01 -> 0.22-unstable-2024-12-26 #368294
base: staging
Are you sure you want to change the base?
Conversation
ca8f9c2
to
9a564c3
Compare
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/5020 |
59faddb
to
51de25e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please include a link to the release notes per the contributing guidelines. Also, please revert to 0.22 with patches to fix the failing test. The reason why this package used an unstable commit before is because a release had not been made in a while, and that is what FreeBSD was using for their build. In general, https://dont-ship.it.
From what I can tell, FreeBSD appears to be shipping ATF 0.22 with the following commit cherry-picked to fix breakage in the test suite: freebsd/atf@b42c986. If that fixes the test failure here, I’d recommend using 0.22 with this patch.
b61dbaf
to
1d114ff
Compare
@reckenrode Done. |
@ofborg build atf |
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.