-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
netbox: 4.1.3 -> 4.1.10 #368036
netbox: 4.1.3 -> 4.1.10 #368036
Conversation
Update to latest 4.1.x version, it should be noted that a testing version for 4.2 is already available.
On an unrelated note, I noticed that |
Reverting to draft, 4.10 requires a thorough update of dependencies. At least django-rq (due to rq) had major version bump with breaking changes. |
An overview of where nixpkgs is and what netbox requires (satisfied-ish versions were skipped):
edit: updates for requirements.txt on tag v4.1.10 |
Create a separate package for the new major version (with breaking changes) of rq. This is an intermediate fix to address netbox however updating python3Packages.rq will likely also be a good idea soon-ish.
For new major version of rq, see previous commit in 368036. This is an intermediate fix for netbox and may be removed in favor of updating django-rq directly.
This vendors and updates the patch for django 5.1 support in netbox 4.1.x. This is required because nixpkgs used django 5.1 but 4.1.x uses django 4.
The patch for Django 5.1 also requires an adjustment for the new |
They don't work. I don't fully understand why but the tests, nor strawberry-graphql, are unstable so this likely is just a development artifact.
cc maintainers of affected packages: @Izorkin @minijackson @RaitoBezarius @mweinelt @happysalada |
Lgtm |
Thanks a lot! There are quite a few packages that fail during I'm also not quite sure if we should be doing separate I can confirm that NetBox tests passes, though! |
@minijackson thank you for trying to get For at least netbox I can now also confirm that this works with plug-ins (except netbox-documents, checks appear broken) in a full deployment. I updated an existing 4.1.3 instance to 4.1.10 without issues. For rq2/django-rq3 my main concern is that other upstream netbox versions like 4.0.x and 3.x relay on rq 1.x. They are supposedly breaking API changes and at least netbox 4.0.x relies on rq 1.x (though maybe it can work with v2, idk). |
netbox has released 4.2.0 and 4.2.1 today. Should I close this PR in favor of updating to 4.2.x directly? |
I'd normally say that packaging 4.1.10 is still useful to backport to 24.11, but it seems even 4.1.10 might prove difficult to backport… |
Okay, then I will close this PR for now and refactore it for 4.2.1. As far as I can tell this should mostly be just a version bump (for packaging) and some more testing. I will also spin off the approved changes for the python dependencies into their own MRs. |
Superseded by #376100 |
Update to latest 4.1.10 version, it should be noted that a testing version for 4.2 is already available.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
.#netbox.passthru.tests.netbox
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Supersedes #366765
Add a 👍 reaction to pull requests you find important.