Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release-24.11] nixos/k3s: use same k3s package in multi-node test #367862

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

nix-backports[bot]
Copy link

@nix-backports nix-backports bot commented Dec 24, 2024

Bot-based backport to release-24.11, triggered by a label in #355964.

  • Before merging, ensure that this backport is acceptable for the release.
    • Even as a non-commiter, if you find that it is not acceptable, leave a comment.

The test previously violated the Kubernetes version skew policy by
deploying a kubelet of hte most recent version in a cluster with an
older apiserver.

(cherry picked from commit 2a79402)
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: k3s Kubernates distribution (https://k3s.io/) 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Dec 24, 2024
@rorosen
Copy link
Contributor

rorosen commented Dec 24, 2024

This should be backported because it fixes a violation of the kubernetes version skew policy in the multi node test. The violation causes the test to be very flaky (it fails almost every time) with recent k3s/kubelet versions. See #352182, #354211 and #355964 for further information.

Currently, the multi node test fails for k3s backports due to this, see #367661 and #367660

@NixOS/k3s

@marcusramberg marcusramberg merged commit 5a69b8d into release-24.11 Dec 26, 2024
35 checks passed
@bjornfor bjornfor deleted the backport-355964-to-release-24.11 branch December 26, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: k3s Kubernates distribution (https://k3s.io/) 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants