Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nvidia-container-toolkit: 1.15.0-rc.3 -> 1.17.3 #367769

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

nvidia-container-toolkit: 1.15.0-rc.3 -> 1.17.3 #367769

wants to merge 1 commit into from
+24 −19

Conversation

ereslibre
Copy link
Member

@ereslibre ereslibre commented Dec 23, 2024 •
edited
Loading

Fixes: #341911

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: nvidia labels Dec 23, 2024
@ereslibre ereslibre mentioned this pull request Dec 23, 2024
Open
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 23, 2024
@ereslibre ereslibre force-pushed the bump-nvidia-container-toolkit branch 3 times, most recently from 74df01b to fd6df1a Compare December 24, 2024 00:16
@ofborg ofborg bot requested a review from cpcloud December 24, 2024 13:35
@ereslibre ereslibre force-pushed the bump-nvidia-container-toolkit branch from fd6df1a to e4bdd22 Compare December 26, 2024 23:04
@ereslibre ereslibre marked this pull request as ready for review December 26, 2024 23:05
@ereslibre ereslibre force-pushed the bump-nvidia-container-toolkit branch from e4bdd22 to 31395de Compare December 26, 2024 23:11
@ereslibre ereslibre mentioned this pull request Jan 1, 2025
Open
@ereslibre ereslibre force-pushed the bump-nvidia-container-toolkit branch 3 times, most recently from 9116aaf to 30db459 Compare January 1, 2025 23:45
@ereslibre ereslibre marked this pull request as draft January 2, 2025 00:00
@ereslibre ereslibre force-pushed the bump-nvidia-container-toolkit branch from 30db459 to 70da757 Compare January 2, 2025 00:11
SomeoneSerge
SomeoneSerge reviewed Jan 2, 2025
View reviewed changes
nixos/modules/services/hardware/nvidia-container-toolkit/cdi-generate.nix
@@ -37,9 +37,9 @@ writeScriptBin "nvidia-cdi-generator" ''
${lib.getExe' nvidia-container-toolkit "nvidia-ctk"} cdi generate \
--format json \
--device-name-strategy ${deviceNameStrategy} \
--ldconfig-path ${lib.getExe' glibc "ldconfig"} \
--ldconfig-path ${lib.getExe' glibc.bin "ldconfig"} \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, I thought getExe would select .bin automatically?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, will update

SomeoneSerge
SomeoneSerge reviewed Jan 2, 2025
View reviewed changes
nixos/modules/services/hardware/nvidia-container-toolkit/cdi-generate.nix
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thank you keeping up the work on nvidia ctk! Anything missing for this PR to be undrafted?

Copy link
Member Author

@ereslibre ereslibre Jan 2, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! I am checking some behaviors with the hooks and in particular with #366109.

When I'm done with the checks I'll move it out of draft. In FHS distros (e.g. ubuntu) I see that hooks are not working as expected and I want to understand what is going on exactly. Similar with NixOS containers, although different, given we don't have ldcache we'd need to fallback to LD_LIBRARY_PATH, but I don't see a good strategy there, given OCI hooks don't allow us to "augment" the envvar (e.g. LD_LIBRARY_PATH=something/new:$LD_LIBRARY_PATH).

I could just bump the version and continue these checks in parallel but let me do a quick check and if I see it's taking longer than expected we can just bump and investigate afterwards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SomeoneSerge SomeoneSerge SomeoneSerge left review comments

@cpcloud cpcloud Awaiting requested review from cpcloud

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: nvidia 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update request: nvidia-container-toolkit 1.15.0-rc.3 → 1.16.1
2 participants
@ereslibre @SomeoneSerge