Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.nbmake: 1.5.4 -> 1.5.5 #367720

Merged
merged 1 commit into from
Dec 28, 2024

Conversation

GaetanLepage
Copy link
Contributor

Things done

Changelog: https://github.com/treebeardtech/nbmake/releases/tag/v1.5.5

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@lucasew
Copy link
Contributor

lucasew commented Dec 23, 2024

Shouldn't this be based on staging because of the amount of rebuilds?

@GaetanLepage GaetanLepage marked this pull request as draft December 23, 2024 20:57
@GaetanLepage GaetanLepage changed the base branch from master to staging December 23, 2024 21:01
@GaetanLepage GaetanLepage marked this pull request as ready for review December 23, 2024 21:01
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Dec 23, 2024
@github-actions github-actions bot removed 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Dec 23, 2024
@GaetanLepage
Copy link
Contributor Author

Shouldn't this be based on staging because of the amount of rebuilds?

Yes, definitely.

@GaetanLepage
Copy link
Contributor Author

@ofborg build python311Packages.nbmake python312Packages.nbmake

@lucasew
Copy link
Contributor

lucasew commented Dec 24, 2024

The workflow did fail because of timeout and the review comment is too long. It also sends the same stuff that would be sent to the review comment in the workflow summary tho.

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+ labels Dec 24, 2024
@GaetanLepage GaetanLepage merged commit cc547db into NixOS:staging Dec 28, 2024
42 of 43 checks passed
@GaetanLepage GaetanLepage deleted the nbmake branch December 28, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants