hyperrogue: 13.0v -> 13.0w #367624
Merged
hyperrogue: 13.0v -> 13.0w #367624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
DimitarNestorov
approved these changes
Dec 28, 2024
DimitarNestorov
added
8.has: package (update)
GaetanLepage
requested changes
Dec 28, 2024
There was a problem hiding this comment.
Can you please:
- Remove the
with lib;in themetaattrs - Add
nativeInstallCheckInputs = [
versionCheckHook
];
versionCheckProgramArg = [ "--version" ];
doInstallCheck = true;after the installPhase.
- Add
passthru = {
updateScript = nix-update-script { };
};just above meta.
- Add
changelog = "https://github.com/zenorogue/hyperrogue/releases/tag/v${version}";in meta
- Remove the "A " from
meta.description(https://nixos.org/manual/nixpkgs/unstable/#var-meta-description) - Re-order the
metaattrs:descriptionhomepagechangelog- (the rest)
GaetanLepage
requested changes
Dec 28, 2024
| }: | ||
|
|
||
| stdenv.mkDerivation rec { | ||
| pname = "hyperrogue"; | ||
| version = "13.0v"; | ||
| version = "13.0w"; | ||
|
|
||
| src = fetchFromGitHub { | ||
| owner = "zenorogue"; | ||
| repo = "hyperrogue"; | ||
| rev = "v${version}"; |
There was a problem hiding this comment.
Suggested change
| rev = "v${version}"; | |
| tag = "v${version}"; |
|
|
Suggestions applied. :) |
wegank
removed
the
12.approvals: 1
| makeDesktopItem, | ||
| fontconfig, | ||
| versionCheckHook, | ||
| nix-update-script, | ||
| }: | ||
|
|
||
| stdenv.mkDerivation rec { |
There was a problem hiding this comment.
Suggested change
| stdenv.mkDerivation rec { | |
| stdenv.mkDerivation (finalAttrs: { |
GaetanLepage
requested changes
Dec 29, 2024
|
|
||
| src = fetchFromGitHub { | ||
| owner = "zenorogue"; | ||
| repo = "hyperrogue"; | ||
| rev = "v${version}"; | ||
| sha256 = "sha256-bH5dnXLWU2D6Y70u7Cy2vqsli1GhID9af4J+21NSPHk="; | ||
| tag = "v${version}"; |
There was a problem hiding this comment.
Suggested change
| tag = "v${version}"; | |
| tag = "v${finalAttrs.version}"; |
| homepage = "https://www.roguetemple.com/z/hyper/"; | ||
| description = "A roguelike game set in hyperbolic geometry"; | ||
| changelog = "https://github.com/zenorogue/hyperrogue/releases/tag/v${version}"; |
There was a problem hiding this comment.
Suggested change
| changelog = "https://github.com/zenorogue/hyperrogue/releases/tag/v${version}"; | |
| changelog = "https://github.com/zenorogue/hyperrogue/releases/tag/v${finalAttrs.version}"; |
|
|
Are you sure that this game is compatible with darwin ? |
|
Also, it might just not be possible to start the game in the sandbox on darwin. |
|
It does have a binary for macos on https://zenorogue.itch.io/hyperrogue so I thought darwin is supported. But I don't have a mac to fix it. 🤷 |
|
khaneliman
approved these changes
Dec 29, 2024
Thanks a lot for testing :) |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #367519
Fix font not found error.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.