Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uv: 0.4.30 -> 0.5.8 #367280

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Conversation

adisbladis
Copy link
Member

@adisbladis adisbladis commented Dec 22, 2024

Things done

This cherry picks changes done to uv on staging.
Uv updates should never have started going to staging and now that decision keeps leaking in to the uv update workflow.
The motivation here is to stop using the staging workflow for uv and go straight to master.

The relatively large rebuild count of uv is caused by a home-assistant test setup hack, and not a reason to keep targeting staging.

See related links for more discussion/complaints:

Note: While 0.5.11 is the latest release 0.5.8 is the latest release that supports rustc <1.83.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

MisileLab and others added 11 commits December 22, 2024 16:21
Signed-off-by: misilelab <[email protected]>
Signed-off-by: misilelaboratory <[email protected]>
Using `buildPythonPackage` triggers dependency propagation, meaning that using `uv` with `nix-shell` results in a a shell with the `uv` Python input in it.
This is problematic for development usage where you only want the one specified version.

Often this design bug in the Python package builders is worked around by deleting `$out/nix-support/propagated-build-inputs`, but since `uv` is written in Rust and can be built without a Python interpreter so it's better to just build without a Python interpreter.
Signed-off-by: misilelaboratory <[email protected]>
Signed-off-by: misilelab <[email protected]>
Signed-off-by: misilelab <[email protected]>
@nix-owners nix-owners bot requested a review from natsukium December 22, 2024 03:34
@adisbladis adisbladis changed the title uv: 0.4.30 -> 0.5.11 uv: 0.4.30 -> 0.5.8 Dec 22, 2024
@MisileLab
Copy link
Contributor

The relatively large rebuild count of uv is caused by a #155060, and not a reason to keep targeting staging.

I targeted staging because 24.11 release was preparing when I submit pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants