Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glib: move to by-name #367270

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
419 changes: 419 additions & 0 deletions pkgs/by-name/gl/glib/package.nix

Large diffs are not rendered by default.

346 changes: 0 additions & 346 deletions pkgs/development/libraries/glib/default.nix

This file was deleted.

2 changes: 1 addition & 1 deletion pkgs/top-level/all-packages.nix
Original file line number Diff line number Diff line change
Expand Up @@ -9298,7 +9298,7 @@ with pkgs;

grantlee = libsForQt5.callPackage ../development/libraries/grantlee { };

glib = callPackage ../development/libraries/glib (let
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove this line

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to break the dependency cycle. I believe this is the closest thing to a standard way that still allows easily overriding the dependencies.

glib = callPackage ../by-name/gl/glib/package.nix (let
glib-untested = glib.overrideAttrs { doCheck = false; };
in {
# break dependency cycles
Expand Down
Loading