gdal: switch to openexr_3 #366939
Open
gdal: switch to openexr_3 #366939
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
10.rebuild-darwin: 0
ofborg
bot
added
the
11.by: package-maintainer
|
I agree with this change. Thanks for acting on this so quickly @autra . Running nixpkgs-review now. |
|
Flagging as security related. |
LeSuisse
added
1.severity: security
|
Result of 15 packages marked as broken and skipped:
1 package failed to build:
162 packages built:
|
imincik
approved these changes
Dec 22, 2024
|
I think, even more correct solution would be to update default openexr version from 2 to 3 . But that's much bigger task. |
Indeed. Should v2 be marked as insecure? (can we affort that?) It's a bit above my paygrade but some of these CVEs seems quite serious. Someone more knowledgeable in security should check though :-) |
13 tasks
|
I've opened a followup: #367406 for the rest of the packages. |
Make a sense to mark v2 as insecure. |
wegank
added
12.approvals: 1
Before we can remove it, it would probably make sense to move all the packages currently using |
And actually I guess this PR should go to staging too. |
autra
force-pushed
the
gdal_openexr_3
branch
from
26eb3f0 to
4b4b377
Compare
|
I changed the base to staging, and I'm going to do that as well for #367406 |
github-actions
bot
removed
6.topic: qt/kde
6.topic: kernel
|
The PR's base branch is set to master, but 254 commits from the staging branch are included. Make sure you know the right base branch for your changes, then:
|
|
We don't need to go via |
ofborg
bot
added
2.status: merge conflict
There are several CVEs affecting openexr v2 and it seems to disturb people. As gdal supports openexr v3, let's live in the future and upgrade this dep. Fix NixOS#366916
autra
force-pushed
the
gdal_openexr_3
branch
from
4b4b377 to
8112df3
Compare
|
Ok, fair enough, I rebased and switched the base branch back to master. |
imincik
approved these changes
Dec 31, 2024
|
wegank
added
the
12.approvals: 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several CVEs affecting openexr v2 and it seems to disturb people. As gdal supports openexr v3, let's live in the future and upgrade this dep.
Fix #366916
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.