Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ghost-cli: init at 1.26.1 #366378

Merged
merged 2 commits into from
Dec 30, 2024
Merged

ghost-cli: init at 1.26.1 #366378

merged 2 commits into from
Dec 30, 2024

Conversation

cything
Copy link
Contributor

@cything cything commented Dec 19, 2024

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Dec 19, 2024
@cything cything changed the title gost-cli: init at 1.26.1 ghost-cli: init at 1.26.1 Dec 19, 2024
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1 10.rebuild-linux: 1 labels Dec 19, 2024
Copy link
Member

@DimitarNestorov DimitarNestorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also add a version test:

  passthru.tests = {
    version = testers.testVersion {
      package = ghost-cli;
    };
  };

LGTM

Manual tests
[nix-shell:~/.cache/nixpkgs-review/pr-366378]$ ghost
No command specified. Run `ghost help` for usage

[nix-shell:~/.cache/nixpkgs-review/pr-366378]$ ghost --version

Love open source? We’re hiring JavaScript Engineers to work on Ghost full-time.
https://careers.ghost.org


Ghost-CLI version: 1.26.1

[nix-shell:~/.cache/nixpkgs-review/pr-366378]$ ghost help
ghost [command]

Commands:
  ghost backup                 Backup content & files
  ghost buster                 Who ya gonna call? (Runs `yarn cache clean`)
  ghost check-update           Check if an update is available for a Ghost installation
  ghost config [key] [value]   View or edit Ghost configuration
  ghost doctor [categories..]  Check the system for any potential hiccups when installing/updating Ghost
  ghost export file            Export content from a blog
  ghost import [file]          Import a Ghost export
  ghost install [version]      Install a brand new instance of Ghost
  ghost log [name]             View the logs of a Ghost instance
  ghost ls                     View running ghost processes
  ghost migrate                Run system migrations on a Ghost instance
  ghost restart                Restart the Ghost instance
  ghost run                    Run a Ghost instance directly (used by process managers and for debugging)
  ghost setup [stages..]       Setup an installation of Ghost (after it is installed)
  ghost start [name]           Start an instance of Ghost
  ghost stop [name]            Stops an instance of Ghost
  ghost uninstall              Remove a Ghost instance and any related configuration files
  ghost update [version]       Update a Ghost instance
  ghost version                Prints out Ghost-CLI version (and Ghost version if one exists)

Global Options:
      --help         Show help                                                                            [boolean]
  -d, --dir          Folder to run command in
  -D, --development  Run in development mode                                                              [boolean]
  -V, --verbose      Enable verbose output                                                                [boolean]
      --prompt       [--no-prompt] Allow/Disallow UI prompting                            [boolean] [default: true]
      --color        [--no-color] Allow/Disallow colorful logging                         [boolean] [default: true]
      --auto         Automatically run as much as possible                               [boolean] [default: false]

For more information, see our docs at https://ghost.org/docs/ghost-cli/

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 366378


aarch64-darwin

✅ 1 package built:
  • ghost-cli

@DimitarNestorov DimitarNestorov added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 22, 2024
@cything
Copy link
Contributor Author

cything commented Dec 22, 2024

I used versionCheckHook instead cause the docs seem to prefer that. Also rebased it on top of master.

@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 23, 2024
pkgs/by-name/gh/ghost-cli/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/gh/ghost-cli/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/gh/ghost-cli/package.nix Outdated Show resolved Hide resolved
Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks !

@cything
Copy link
Contributor Author

cything commented Dec 30, 2024

LGTM, thanks !

Thanks for the review and suggestions!

@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 366378


x86_64-linux

✅ 1 package built:
  • ghost-cli

aarch64-linux

✅ 1 package built:
  • ghost-cli

x86_64-darwin

✅ 1 package built:
  • ghost-cli

aarch64-darwin

✅ 1 package built:
  • ghost-cli

@GaetanLepage GaetanLepage merged commit b5e20c7 into NixOS:master Dec 30, 2024
59 of 60 checks passed
@cything cything deleted the ghost branch December 30, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants