-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ghost-cli: init at 1.26.1 #366378
ghost-cli: init at 1.26.1 #366378
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can also add a version test:
passthru.tests = {
version = testers.testVersion {
package = ghost-cli;
};
};
LGTM
Manual tests
[nix-shell:~/.cache/nixpkgs-review/pr-366378]$ ghost
No command specified. Run `ghost help` for usage
[nix-shell:~/.cache/nixpkgs-review/pr-366378]$ ghost --version
Love open source? We’re hiring JavaScript Engineers to work on Ghost full-time.
https://careers.ghost.org
Ghost-CLI version: 1.26.1
[nix-shell:~/.cache/nixpkgs-review/pr-366378]$ ghost help
ghost [command]
Commands:
ghost backup Backup content & files
ghost buster Who ya gonna call? (Runs `yarn cache clean`)
ghost check-update Check if an update is available for a Ghost installation
ghost config [key] [value] View or edit Ghost configuration
ghost doctor [categories..] Check the system for any potential hiccups when installing/updating Ghost
ghost export file Export content from a blog
ghost import [file] Import a Ghost export
ghost install [version] Install a brand new instance of Ghost
ghost log [name] View the logs of a Ghost instance
ghost ls View running ghost processes
ghost migrate Run system migrations on a Ghost instance
ghost restart Restart the Ghost instance
ghost run Run a Ghost instance directly (used by process managers and for debugging)
ghost setup [stages..] Setup an installation of Ghost (after it is installed)
ghost start [name] Start an instance of Ghost
ghost stop [name] Stops an instance of Ghost
ghost uninstall Remove a Ghost instance and any related configuration files
ghost update [version] Update a Ghost instance
ghost version Prints out Ghost-CLI version (and Ghost version if one exists)
Global Options:
--help Show help [boolean]
-d, --dir Folder to run command in
-D, --development Run in development mode [boolean]
-V, --verbose Enable verbose output [boolean]
--prompt [--no-prompt] Allow/Disallow UI prompting [boolean] [default: true]
--color [--no-color] Allow/Disallow colorful logging [boolean] [default: true]
--auto Automatically run as much as possible [boolean] [default: false]
For more information, see our docs at https://ghost.org/docs/ghost-cli/
nixpkgs-review
result
Generated using nixpkgs-review
.
Command: nixpkgs-review pr 366378
aarch64-darwin
✅ 1 package built:
- ghost-cli
I used |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks !
Thanks for the review and suggestions! |
|
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.