Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bigpemu: init at 1.17 #366367

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

bigpemu: init at 1.17 #366367

wants to merge 2 commits into from
+68 −0

Conversation

Tombert
Copy link
Contributor

@Tombert Tombert commented Dec 18, 2024

Make BigPEmu work in Nixos. Already tested in a flake (https://github.com/Tombert/BigPEmuFlakeMake).

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Tombert Tombert force-pushed the bigpemu branch 9 times, most recently from 07d8e50 to a403e40 Compare December 19, 2024 00:09
@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Dec 19, 2024
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 19, 2024
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin labels Dec 19, 2024
@hughobrien
Copy link
Contributor

I suggest splitting into two commits with one being: maintainers: add tombert

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin and removed 10.rebuild-darwin: 1 10.rebuild-darwin: 1-10 10.rebuild-linux: 1 labels Dec 22, 2024
@Tombert Tombert force-pushed the bigpemu branch 3 times, most recently from 5a88161 to 25aeda7 Compare December 22, 2024 06:17
@hughobrien
Copy link
Contributor

Updater script: https://github.com/hughobrien/nixpkgs/tree/bigpemu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hughobrien hughobrien hughobrien left review comments

Assignees
No one assigned
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tombert @hughobrien