Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.basedmypy: init at 2.8.1 #364818

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

python3Packages.basedmypy: init at 2.8.1 #364818

wants to merge 1 commit into from
+137 −0

Conversation

PerchunPak
Copy link
Member

@PerchunPak PerchunPak commented Dec 13, 2024 •
edited
Loading

Depends on #364817 merged

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@PerchunPak PerchunPak mentioned this pull request Dec 13, 2024
Merged
13 tasks
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes labels Dec 13, 2024
SuperSandro2000
SuperSandro2000 reviewed Dec 23, 2024
View reviewed changes
pkgs/development/python-modules/basedmypy/default.nix Outdated
[ ]
++ lib.optionals (pythonAtLeast "3.12") [
# requires distutils
"test_c_unit_test"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not add distutils to fix this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I add distutils to nativeCheckInputs, build crashes with Skipping analyzing "distutils": module is installed, but missing library stubs or py.typed marker. (distutils stubs are in types-setuptools which should already be installed) during the buildPhase

@PerchunPak PerchunPak marked this pull request as ready for review December 23, 2024 08:37
@nix-owners nix-owners bot requested a review from natsukium December 23, 2024 08:38
@PerchunPak

This comment was marked as resolved.

Sign in to view
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/5037

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natsukium natsukium Awaiting requested review from natsukium

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PerchunPak @nixos-discourse @SuperSandro2000