Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

equicord: 1.10.6 -> 1.10.8; add update script #364064

Merged
merged 2 commits into from
Dec 28, 2024
Merged

Conversation

NotAShelf
Copy link
Member

@NotAShelf NotAShelf commented Dec 10, 2024

  • equicord: 1.10.6 -> 1.10.8
  • equicord: add passthru.updateScript

Bumps Equicord and adds an update script.

We intentionally avoid the tag attribute, since it caused a build failure for
me due to finalAttrs.src.tag missing.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@NotAShelf NotAShelf marked this pull request as draft December 10, 2024 23:48
@NotAShelf NotAShelf force-pushed the equibump branch 2 times, most recently from 5f145af to 4e497ab Compare December 10, 2024 23:52
@NotAShelf NotAShelf marked this pull request as ready for review December 10, 2024 23:54
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 10.rebuild-linux: 1-10 and removed 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Dec 10, 2024
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-linux: 1 labels Dec 11, 2024
@NotAShelf
Copy link
Member Author

@JohnRTitor think you could merge this? We're lagging behind upstream a little bit.

@JohnRTitor JohnRTitor merged commit cb446e2 into NixOS:master Dec 28, 2024
41 of 42 checks passed
@NotAShelf
Copy link
Member Author

Thank you :)

@NotAShelf NotAShelf added backport staging-24.11 Backport PR automatically 9.needs: port to stable A PR needs a backport to the stable release. labels Dec 30, 2024
@NotAShelf NotAShelf deleted the equibump branch December 30, 2024 06:44
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Dec 30, 2024

Backport failed for staging-24.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin staging-24.11
git worktree add -d .worktree/backport-364064-to-staging-24.11 origin/staging-24.11
cd .worktree/backport-364064-to-staging-24.11
git switch --create backport-364064-to-staging-24.11
git cherry-pick -x 7cd8111802d989f514ce61ea91151477ef5d134a 930c4ea2d7a9fce9fff266692befabd515ea4069

1 similar comment
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Dec 30, 2024

Backport failed for staging-24.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin staging-24.11
git worktree add -d .worktree/backport-364064-to-staging-24.11 origin/staging-24.11
cd .worktree/backport-364064-to-staging-24.11
git switch --create backport-364064-to-staging-24.11
git cherry-pick -x 7cd8111802d989f514ce61ea91151477ef5d134a 930c4ea2d7a9fce9fff266692befabd515ea4069

@JohnRTitor JohnRTitor added backport release-24.11 Backport PR automatically and removed backport staging-24.11 Backport PR automatically labels Dec 30, 2024
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Dec 30, 2024

Backport failed for release-24.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-24.11
git worktree add -d .worktree/backport-364064-to-release-24.11 origin/release-24.11
cd .worktree/backport-364064-to-release-24.11
git switch --create backport-364064-to-release-24.11
git cherry-pick -x 7cd8111802d989f514ce61ea91151477ef5d134a 930c4ea2d7a9fce9fff266692befabd515ea4069

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes backport release-24.11 Backport PR automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants