davinci-resolve: migrate to by-name & 19.1 -> 19.1.1 #362268
Open
+5
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jshcmpbll
added
the
11.by: package-maintainer
github-actions
bot
added
10.rebuild-darwin: 0
jshcmpbll
force-pushed
the
jc/davinci-resolve-by-name
branch
from
bd2891b to
715d002
Compare
pyrox0
reviewed
Dec 6, 2024
jshcmpbll
force-pushed
the
jc/davinci-resolve-by-name
branch
from
715d002 to
4dc808d
Compare
|
lgtm, but I can't test it atm since it would need me to build spidermonkey from source. |
pyrox0
approved these changes
Dec 6, 2024
wegank
added
the
12.approvals: 1
wegank
added
the
2.status: merge conflict
jshcmpbll
force-pushed
the
jc/davinci-resolve-by-name
branch
2 times, most recently
from
4bbce58 to
bffb748
Compare
jshcmpbll
removed
the
2.status: merge conflict
wegank
removed
the
12.approvals: 1
amarshall
reviewed
Dec 13, 2024
| @@ -278,7 +278,7 @@ buildFHSEnv { | |||
| ]; | |||
| text = '' | |||
| set -o errexit | |||
| drv=pkgs/by-name/da/davinci-resolve/package.nix | |||
| drv=pkgs/applications/video/davinci-resolve/default.nix | |||
There was a problem hiding this comment.
Yes, looks like I made a mistake during my rebase
jshcmpbll
force-pushed
the
jc/davinci-resolve-by-name
branch
from
bffb748 to
7e90bfd
Compare
amarshall
approved these changes
Dec 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrating davinci-resolve to
by-nameand also bumping the package version.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.