Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tilp: init at 1.18 #359950

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

tilp: init at 1.18 #359950

wants to merge 1 commit into from

Conversation

myclevorname
Copy link
Contributor

TILP is a program that allows for communication with TI graphing calculators. TILP was added to Nixpkgs in 2020, but was dropped in 2022 due to its dependency on libglade, which wasn't actually necessary. Fixes CE-Programming/CEmu#507

I renamed the package to tilp due to this guideline:

  • For the pname attribute:

    • It should be identical to the upstream package name.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Contributor

@steeleduncan steeleduncan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In principle you could add an update script, but maybe it is pointless given how long it has been since there was an update

src = fetchFromGitHub {
owner = "debrouxl";
repo = "tilp_and_gfm";
rev = "9fb0fab9e91b5d5a43a1d907197734264b68fc6d";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rev="refs/tags/${finalAttrs.version}"

@debrouxl
Copy link

libti*/gfm/tilp keep evolving, and 1.18 is ancient by now... but I seldom make releases, I know :)
Some distros package the Git master HEAD - and rightfully so.

@steeleduncan
Copy link
Contributor

Some distros package the Git master HEAD

sure, but in that case you shouldn't be declaring the version as 1.18, which is not a true statement in the PR as it stands

gtk2
];
meta = {
description = "TILP is a program allowing a computer to communicate with TI graphing calculators";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description = "TILP is a program allowing a computer to communicate with TI graphing calculators";
description = "Communicate with TI graphing calculators";

@Aleksanaa
Copy link
Member

Some distros package the Git master HEAD - and rightfully so.

Another issue here is that we may not accept new gtk2 apps because gtk2 has long deprecated, and we are also working on removing or updating gtk2 packages.

@debrouxl
Copy link

I did the bulk of the work porting the code of TILP to GTK+3 in 2013-2014. However, this work has always remained on a non-default branch, and apart from the secondary computer where I did that porting and initial testing work, I kept using the GTK+2 version myself, because of the historic Windows build.
Now that Linux distros are removing GTK+2, and a new Windows build is being improved, I should just finish integrating the GTK+3 work to the main branch, and use the GTK+3 version myself.

@myclevorname myclevorname marked this pull request as draft December 1, 2024 04:29
@myclevorname myclevorname added the 2.status: wait-for-upstream Waiting for upstream fix (or their other action). label Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: wait-for-upstream Waiting for upstream fix (or their other action). 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ERR: VERSION
4 participants