-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tilp: init at 1.18 #359950
base: master
Are you sure you want to change the base?
tilp: init at 1.18 #359950
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In principle you could add an update script, but maybe it is pointless given how long it has been since there was an update
src = fetchFromGitHub { | ||
owner = "debrouxl"; | ||
repo = "tilp_and_gfm"; | ||
rev = "9fb0fab9e91b5d5a43a1d907197734264b68fc6d"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rev="refs/tags/${finalAttrs.version}"
libti*/gfm/tilp keep evolving, and 1.18 is ancient by now... but I seldom make releases, I know :) |
sure, but in that case you shouldn't be declaring the version as 1.18, which is not a true statement in the PR as it stands |
gtk2 | ||
]; | ||
meta = { | ||
description = "TILP is a program allowing a computer to communicate with TI graphing calculators"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description = "TILP is a program allowing a computer to communicate with TI graphing calculators"; | |
description = "Communicate with TI graphing calculators"; |
Another issue here is that we may not accept new gtk2 apps because gtk2 has long deprecated, and we are also working on removing or updating gtk2 packages. |
I did the bulk of the work porting the code of TILP to GTK+3 in 2013-2014. However, this work has always remained on a non-default branch, and apart from the secondary computer where I did that porting and initial testing work, I kept using the GTK+2 version myself, because of the historic Windows build. |
TILP is a program that allows for communication with TI graphing calculators. TILP was added to Nixpkgs in 2020, but was dropped in 2022 due to its dependency on libglade, which wasn't actually necessary. Fixes CE-Programming/CEmu#507
I renamed the package to tilp due to this guideline:
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.