Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gomobile: 2022-05-18 -> 0-unstable-2024-12-13 #359914

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

gomobile: 2022-05-18 -> 0-unstable-2024-12-13 #359914

wants to merge 2 commits into from
+39 −27

Conversation

aucub
Copy link
Contributor

@aucub aucub commented Nov 28, 2024

Fixes #256559

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 29, 2024
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4897

@pbsds
Copy link
Member

pbsds commented Dec 1, 2024

Neither ofborg nor nixpkgs-review with --eval local can detect any changed packages. Any ideas as to why?

@aucub aucub force-pushed the gomobile branch 2 times, most recently from 7f8fbd5 to d13101c Compare December 4, 2024 13:39
@aucub aucub changed the title gomobile: 2022-05-18 -> 0-unstable-2024-11-8 gomobile: 2022-05-18 -> 0-unstable-2024-11-08 Dec 4, 2024
@aucub aucub marked this pull request as draft December 9, 2024 00:53
@aucub aucub force-pushed the gomobile branch 4 times, most recently from 6fa776d to 3c966a2 Compare December 9, 2024 01:15
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Dec 9, 2024
@aucub aucub force-pushed the gomobile branch 5 times, most recently from 4fe64ef to 5920cfd Compare December 9, 2024 01:57
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux and removed 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Dec 9, 2024
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Dec 9, 2024
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux and removed 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Dec 9, 2024
@aucub
Copy link
Contributor Author

aucub commented Dec 9, 2024

Neither ofborg nor nixpkgs-review with --eval local can detect any changed packages. Any ideas as to why?

Because using androidenv

@aucub aucub force-pushed the gomobile branch 2 times, most recently from 9a96f4c to 5da2f6d Compare December 9, 2024 02:38
@aucub aucub marked this pull request as ready for review December 9, 2024 02:38
@aucub aucub force-pushed the gomobile branch 2 times, most recently from e4f4f00 to fc82d13 Compare December 9, 2024 13:21
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4969

@aucub aucub marked this pull request as draft December 21, 2024 17:13
@thiagokokada
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 359914

@aucub aucub force-pushed the gomobile branch 2 times, most recently from 7cfb3d7 to 32236c0 Compare December 21, 2024 17:38
@aucub aucub changed the title gomobile: 2022-05-18 -> 0-unstable-2024-11-08 gomobile: 2022-05-18 -> 0-unstable-2024-12-13 Dec 21, 2024
@aucub aucub marked this pull request as ready for review December 21, 2024 17:42
@aucub
Copy link
Contributor Author

aucub commented Dec 21, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 359914 --extra-nixpkgs-config '{ allowUnfree = true; android_sdk.accept_license = true; cudaSupport = true; }'

x86_64-linux

✅ 1 package built:
  • gomobile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update request: gomobile 2022-05-18 → v0.0.0-20230906132913-2077a3224571
5 participants
@aucub @nixos-discourse @pbsds @thiagokokada @SuperSandro2000