nixos/crproxy: init module crproxy #356098
Open
+207
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a generic image proxy for dockerhub, see https://github.com/DaoCloud/crproxy/releases/tag/v0.12.2
github-actions
bot
added
6.topic: nixos
NixOSInfra
added
the
12. first-time contribution
ofborg
bot
added
8.has: package (new)
FliegendeWurst
requested changes
Dec 29, 2024
Co-authored-by: Arne Keller <[email protected]>
senseab
commented
Dec 30, 2024
Co-authored-by: Arne Keller <[email protected]>
Co-authored-by: Arne Keller <[email protected]>
Co-authored-by: Arne Keller <[email protected]>
Co-authored-by: Arne Keller <[email protected]>
update description of `listenAddress` Co-authored-by: Arne Keller <[email protected]>
Co-authored-by: Arne Keller <[email protected]>
| privilegedIPList = mkOption { | ||
| default = [ ]; | ||
| type = types.listOf types.str; | ||
| description = "privileged IP list"; |
There was a problem hiding this comment.
What is a "privileged IP" here? Please add that info to the description.
There was a problem hiding this comment.
I have updated the code, see the latest version
| simpleAuthUser = mkOption { | ||
| type = types.listOf types.str; | ||
| default = [ ]; | ||
| description = "simple auth user and password (default [])"; |
There was a problem hiding this comment.
Please add an example showing how to use this.
| true | ||
| ''; | ||
| type = types.bool; | ||
| description = "Behind the reverse proxy, such as nginx"; |
There was a problem hiding this comment.
What effect does this option have?
There was a problem hiding this comment.
This option is enabled when the crproxy is fronted by nginx, allowing it to receive HTTP headers from nginx and ensuring that the crproxy can function properly.
Co-authored-by: Arne Keller <[email protected]>
Co-authored-by: Arne Keller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a generic image proxy for dockerhub, see https://github.com/DaoCloud/crproxy/releases/tag/v0.12.2
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.