postgresql: drop build-time dependency on GHC

[Ma27]

This replaces writeShellApplication with writeShellScriptBin that doesn't perform a shellcheck. This makes it way easier to build postgresql on staging since GHC is super slow to build, even with pretty powerful machines.

Also Haskell updates are currently merged straight into master which means that postgresql and all reverse dependencies require a rebuild on master then[1].

[1] #354270 (comment)

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[wolfgangwalther]

Makes total sense. If we ever come around to doing something like #353490, then the separate .sh file would be checked that way.

[wolfgangwalther]

I'm not sure about the shebang and the shell options that this might change. Do we need to do some set -e etc.? The docs for writeShellApplication suggest that this does a bit more than writeShellScriptBin.

[Ma27]

Good point, added the options that writeShellAPplication added.

[sternenseemann]

Makes total sense. If we ever come around to doing something like #353490, then the separate .sh file would be checked that way.

It is probably also feasible to add passthru.tests for this. I was considering whether writeShellApplication should maybe have a flag (for in nixpkgs use) that moves the checkPhase to passthru.tests.

[wolfgangwalther]

Makes total sense. If we ever come around to doing something like #353490, then the separate .sh file would be checked that way.

It is probably also feasible to add passthru.tests for this. I was considering whether writeShellApplication should maybe have a flag (for in nixpkgs use) that moves the checkPhase to passthru.tests.

That would make it possible to check all setup hooks, too, because it avoids the bootstrap-problem. But, we have a few more shell scripts in the repo that are not connected to nix code, imho. So the CI check should be able to work on more files.