stdenv: fix documentation for stripAllFlags and stripDebugFlags #352127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation for the default flags used for both fields were incomplete.
github-actions
bot
added
the
8.has: documentation
ofborg
bot
added
10.rebuild-darwin: 0
|
https://sourceware.org/binutils/docs/binutils.html#strip is the command reference for |
philiptaron
approved these changes
Dec 13, 2024
| @@ -886,7 +886,7 @@ Like `stripAllList`, but only applies to packages’ target platform. By default | |||
|
|
|||
| ##### `stripAllFlags` {#var-stdenv-stripAllFlags} | |||
|
|
|||
| Flags passed to the `strip` command applied to the files in the directories listed in `stripAllList`. Defaults to `-s` (i.e. `--strip-all`). | |||
| Flags passed to the `strip` command applied to the files in the directories listed in `stripAllList`. Defaults to `-s -p` (i.e. `--strip-all --preserve-dates`). | |||
There was a problem hiding this comment.
Source of truth:
| @@ -898,7 +898,7 @@ Like `stripDebugList`, but only applies to packages’ target platform. By defau | |||
|
|
|||
| ##### `stripDebugFlags` {#var-stdenv-stripDebugFlags} | |||
|
|
|||
| Flags passed to the `strip` command applied to the files in the directories listed in `stripDebugList`. Defaults to `-S` (i.e. `--strip-debug`). | |||
| Flags passed to the `strip` command applied to the files in the directories listed in `stripDebugList`. Defaults to `-S -p` (i.e. `--strip-debug --preserve-dates`). | |||
There was a problem hiding this comment.
Source of truth:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation for the default flags used for both fields were incomplete.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.