Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python312Packages.torchmetrics: 1.4.3 -> 1.6.1 #350488

Merged
merged 1 commit into from
Jan 2, 2025
Merged

python312Packages.torchmetrics: 1.4.3 -> 1.6.1 #350488

merged 1 commit into from
Jan 2, 2025

Conversation

GaetanLepage
Copy link
Contributor

@GaetanLepage GaetanLepage commented Oct 22, 2024 •
edited
Loading

Things done

Changelogs:

cc @SomeoneSerge

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@GaetanLepage
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 350488

x86_64-linux

⏩ 6 packages marked as broken and skipped:
  • piper-train
  • piper-train.dist
  • python311Packages.elegy
  • python311Packages.elegy.dist
  • python311Packages.treex
  • python311Packages.treex.dist
✅ 18 packages built:
  • python311Packages.finetuning-scheduler
  • python311Packages.finetuning-scheduler.dist
  • python311Packages.pyannote-audio
  • python311Packages.pyannote-audio.dist
  • python311Packages.pytorch-lightning
  • python311Packages.pytorch-lightning.dist
  • python311Packages.torchmetrics
  • python311Packages.torchmetrics.dist
  • python312Packages.finetuning-scheduler
  • python312Packages.finetuning-scheduler.dist
  • python312Packages.pyannote-audio
  • python312Packages.pyannote-audio.dist
  • python312Packages.pytorch-lightning
  • python312Packages.pytorch-lightning.dist
  • python312Packages.torchmetrics
  • python312Packages.torchmetrics.dist
  • whisper-ctranslate2
  • whisper-ctranslate2.dist

aarch64-linux

⏩ 6 packages marked as broken and skipped:
  • piper-train
  • piper-train.dist
  • python311Packages.elegy
  • python311Packages.elegy.dist
  • python311Packages.treex
  • python311Packages.treex.dist
❌ 2 packages failed to build:
  • whisper-ctranslate2
  • whisper-ctranslate2.dist
✅ 16 packages built:
  • python311Packages.finetuning-scheduler
  • python311Packages.finetuning-scheduler.dist
  • python311Packages.pyannote-audio
  • python311Packages.pyannote-audio.dist
  • python311Packages.pytorch-lightning
  • python311Packages.pytorch-lightning.dist
  • python311Packages.torchmetrics
  • python311Packages.torchmetrics.dist
  • python312Packages.finetuning-scheduler
  • python312Packages.finetuning-scheduler.dist
  • python312Packages.pyannote-audio
  • python312Packages.pyannote-audio.dist
  • python312Packages.pytorch-lightning
  • python312Packages.pytorch-lightning.dist
  • python312Packages.torchmetrics
  • python312Packages.torchmetrics.dist

x86_64-darwin

⏩ 4 packages marked as broken and skipped:
  • python311Packages.finetuning-scheduler
  • python311Packages.finetuning-scheduler.dist
  • python312Packages.finetuning-scheduler
  • python312Packages.finetuning-scheduler.dist
✅ 8 packages built:
  • python311Packages.pytorch-lightning
  • python311Packages.pytorch-lightning.dist
  • python311Packages.torchmetrics
  • python311Packages.torchmetrics.dist
  • python312Packages.pytorch-lightning
  • python312Packages.pytorch-lightning.dist
  • python312Packages.torchmetrics
  • python312Packages.torchmetrics.dist

aarch64-darwin

⏩ 8 packages marked as broken and skipped:
  • python311Packages.elegy
  • python311Packages.elegy.dist
  • python311Packages.finetuning-scheduler
  • python311Packages.finetuning-scheduler.dist
  • python311Packages.treex
  • python311Packages.treex.dist
  • python312Packages.finetuning-scheduler
  • python312Packages.finetuning-scheduler.dist
❌ 2 packages failed to build:
  • python311Packages.pyannote-audio
  • python311Packages.pyannote-audio.dist
✅ 12 packages built:
  • python311Packages.pytorch-lightning
  • python311Packages.pytorch-lightning.dist
  • python311Packages.torchmetrics
  • python311Packages.torchmetrics.dist
  • python312Packages.pyannote-audio
  • python312Packages.pyannote-audio.dist
  • python312Packages.pytorch-lightning
  • python312Packages.pytorch-lightning.dist
  • python312Packages.torchmetrics
  • python312Packages.torchmetrics.dist
  • whisper-ctranslate2
  • whisper-ctranslate2.dist

@SomeoneSerge
Copy link
Contributor

aarch64 failure is new https://hydra.nixos.org/build/276257303

@GaetanLepage GaetanLepage changed the title python312Packages.torchmetrics: 1.4.3 -> 1.5.0 python312Packages.torchmetrics: 1.4.3 -> 1.5.1 Oct 23, 2024
@GaetanLepage
Copy link
Contributor Author

aarch64 failure is new https://hydra.nixos.org/build/276257303

Indeed :'(
I have no idea why though:

terminate called after throwing an instance of 'onnxruntime::OnnxRuntimeException'
  what():  /build/source/include/onnxruntime/core/common/logging/logging.h:320 static const onnxruntime::logging::Logger& onnxruntime::logging::LoggingManager::DefaultLogger() Attempt to use DefaultLogger but none has been registered.

@GaetanLepage
Copy link
Contributor Author

I bisected it to this commit.

What is very strange is that this bug happens only:

  • on aarch64-linux
  • within a 3-layer deep downstream dependency (torchmetrics -> pytorch-lightning -> pyannote-audio -> whisper-ctranslate2).

@autrimpo
Copy link
Contributor

FYI it builds fine for me with sandbox disabled.

@GaetanLepage GaetanLepage force-pushed the torchmetrics branch 2 times, most recently from c2a6888 to e681f60 Compare November 10, 2024 22:52
@GaetanLepage GaetanLepage changed the title python312Packages.torchmetrics: 1.4.3 -> 1.5.1 python312Packages.torchmetrics: 1.4.3 -> 1.5.2 Nov 10, 2024
@GaetanLepage GaetanLepage changed the title python312Packages.torchmetrics: 1.4.3 -> 1.5.2 python312Packages.torchmetrics: 1.4.3 -> 1.6.0 Dec 1, 2024
@GaetanLepage GaetanLepage marked this pull request as draft December 2, 2024 17:23
@khaneliman
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 350488

x86_64-linux

⏩ 10 packages marked as broken and skipped:
  • piper-train
  • piper-train.dist
  • python311Packages.elegy
  • python311Packages.elegy.dist
  • python311Packages.treex
  • python311Packages.treex.dist
  • python312Packages.elegy
  • python312Packages.elegy.dist
  • python312Packages.treex
  • python312Packages.treex.dist
✅ 18 packages built:
  • python311Packages.finetuning-scheduler
  • python311Packages.finetuning-scheduler.dist
  • python311Packages.pyannote-audio
  • python311Packages.pyannote-audio.dist
  • python311Packages.pytorch-lightning
  • python311Packages.pytorch-lightning.dist
  • python311Packages.torchmetrics
  • python311Packages.torchmetrics.dist
  • python312Packages.finetuning-scheduler
  • python312Packages.finetuning-scheduler.dist
  • python312Packages.pyannote-audio
  • python312Packages.pyannote-audio.dist
  • python312Packages.pytorch-lightning
  • python312Packages.pytorch-lightning.dist
  • python312Packages.torchmetrics
  • python312Packages.torchmetrics.dist
  • whisper-ctranslate2
  • whisper-ctranslate2.dist

aarch64-linux

⏩ 10 packages marked as broken and skipped:
  • piper-train
  • piper-train.dist
  • python311Packages.elegy
  • python311Packages.elegy.dist
  • python311Packages.treex
  • python311Packages.treex.dist
  • python312Packages.elegy
  • python312Packages.elegy.dist
  • python312Packages.treex
  • python312Packages.treex.dist
❌ 2 packages failed to build:
  • whisper-ctranslate2
  • whisper-ctranslate2.dist
✅ 16 packages built:
  • python311Packages.finetuning-scheduler
  • python311Packages.finetuning-scheduler.dist
  • python311Packages.pyannote-audio
  • python311Packages.pyannote-audio.dist
  • python311Packages.pytorch-lightning
  • python311Packages.pytorch-lightning.dist
  • python311Packages.torchmetrics
  • python311Packages.torchmetrics.dist
  • python312Packages.finetuning-scheduler
  • python312Packages.finetuning-scheduler.dist
  • python312Packages.pyannote-audio
  • python312Packages.pyannote-audio.dist
  • python312Packages.pytorch-lightning
  • python312Packages.pytorch-lightning.dist
  • python312Packages.torchmetrics
  • python312Packages.torchmetrics.dist

x86_64-darwin

⏩ 4 packages marked as broken and skipped:
  • python311Packages.finetuning-scheduler
  • python311Packages.finetuning-scheduler.dist
  • python312Packages.finetuning-scheduler
  • python312Packages.finetuning-scheduler.dist
✅ 8 packages built:
  • python311Packages.pytorch-lightning
  • python311Packages.pytorch-lightning.dist
  • python311Packages.torchmetrics
  • python311Packages.torchmetrics.dist
  • python312Packages.pytorch-lightning
  • python312Packages.pytorch-lightning.dist
  • python312Packages.torchmetrics
  • python312Packages.torchmetrics.dist

aarch64-darwin

⏩ 12 packages marked as broken and skipped:
  • python311Packages.elegy
  • python311Packages.elegy.dist
  • python311Packages.finetuning-scheduler
  • python311Packages.finetuning-scheduler.dist
  • python311Packages.treex
  • python311Packages.treex.dist
  • python312Packages.elegy
  • python312Packages.elegy.dist
  • python312Packages.finetuning-scheduler
  • python312Packages.finetuning-scheduler.dist
  • python312Packages.treex
  • python312Packages.treex.dist
✅ 14 packages built:
  • python311Packages.pyannote-audio
  • python311Packages.pyannote-audio.dist
  • python311Packages.pytorch-lightning
  • python311Packages.pytorch-lightning.dist
  • python311Packages.torchmetrics
  • python311Packages.torchmetrics.dist
  • python312Packages.pyannote-audio
  • python312Packages.pyannote-audio.dist
  • python312Packages.pytorch-lightning
  • python312Packages.pytorch-lightning.dist
  • python312Packages.torchmetrics
  • python312Packages.torchmetrics.dist
  • whisper-ctranslate2
  • whisper-ctranslate2.dist

@GaetanLepage GaetanLepage changed the title python312Packages.torchmetrics: 1.4.3 -> 1.6.0 python312Packages.torchmetrics: 1.4.3 -> 1.6.1 Dec 25, 2024
SomeoneSerge
SomeoneSerge approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@SomeoneSerge SomeoneSerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't check the runtime, but the tests pass, the diff looks good, not sure why the draft status

@GaetanLepage GaetanLepage marked this pull request as ready for review January 2, 2025 11:35
@GaetanLepage GaetanLepage merged commit 7cb9646 into NixOS:master Jan 2, 2025
56 of 57 checks passed
@GaetanLepage GaetanLepage deleted the torchmetrics branch January 2, 2025 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SomeoneSerge SomeoneSerge SomeoneSerge approved these changes

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GaetanLepage @SomeoneSerge @autrimpo @khaneliman