Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tpi: init at 1.0.6 #349522

Merged
merged 2 commits into from
Oct 27, 2024
Merged

tpi: init at 1.0.6 #349522

merged 2 commits into from
Oct 27, 2024

Conversation

WoutSwinkels
Copy link
Contributor

CLI tool to control your Turing Pi 2 board developed by Turing Machines.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Oct 18, 2024
@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Oct 18, 2024
FliegendeWurst
FliegendeWurst reviewed Oct 23, 2024
View reviewed changes
Copy link
Member

@FliegendeWurst FliegendeWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Package LGTM overall. By the way, why are your git commits not associated with an email address?

pkgs/by-name/tp/tpi/package.nix Outdated
src = fetchFromGitHub {
owner = "turing-machines";
repo = "tpi";
rev = "v1.0.6";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually this would be "v${version}" or similar

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't aware that I hadn't set my mail address. I use git cmd and set it for each repo separate because I have different mail addresses for GitHub, GitLab and Bitbucket as well as work and private. If I want to apply your suggestions is it preferable to create a new commit or squash the changes in the original commit?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can apply all suggestions and have a single commit tpi: init at 1.0.6

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I will do that and add my email address

Aleksanaa
Aleksanaa reviewed Oct 23, 2024
View reviewed changes
pkgs/by-name/tp/tpi/package.nix Outdated
owner = "turing-machines";
repo = "tpi";
rev = "v1.0.6";
sha256 = "1ax43dbyy41awf7s5x6kcx96dwjl3d2iir1l3qdqlbw9g1ps8jmf";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
sha256 = "1ax43dbyy41awf7s5x6kcx96dwjl3d2iir1l3qdqlbw9g1ps8jmf";
hash = "sha256-rkqkb3iJL4obHjTkGEUbVPJmUmfT9KKP4yoQ71cbpKs=";

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the preferred way?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the correct way.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for clarifying. I will update it

pkgs/by-name/tp/tpi/package.nix Show resolved Hide resolved
FliegendeWurst
FliegendeWurst approved these changes Oct 26, 2024
View reviewed changes
Copy link
Member

@FliegendeWurst FliegendeWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you tested that the package works.

@WoutSwinkels
Copy link
Contributor Author

I assume you tested that the package works.

Yes, I have tested it locally

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 26, 2024
@Aleksanaa Aleksanaa merged commit 3e32c07 into NixOS:master Oct 27, 2024
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aleksanaa Aleksanaa Aleksanaa approved these changes

@FliegendeWurst FliegendeWurst FliegendeWurst approved these changes

Assignees
No one assigned
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@WoutSwinkels @FliegendeWurst @Aleksanaa @wegank @NixOSInfra