Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release-24.05] nixos/ipu6: Don't build out-of-tree driver for kernels that have it #332240

Merged
merged 1 commit into from
Sep 1, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 4, 2024

Closes #337943.


Bot-based backport to release-24.05, triggered by a label in #331747.

  • Before merging, ensure that this backport is acceptable for the release.
    • Even as a non-commiter, if you find that it is not acceptable, leave a comment.

@flokli
Copy link
Contributor

flokli commented Aug 4, 2024

See #331747 (comment), unclear if this actually works.

@ofborg ofborg bot added 8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Aug 4, 2024
@seqizz
Copy link
Contributor

seqizz commented Aug 19, 2024

Camera does not work in any case (at least for me) but without this patch we'd be getting following errors on build-time, no?

     error: A definition for option `boot.extraModulePackages."[definition 3-entry 1]"' is not of type `package'. Definition values:
       - In `/nix/store/wbqb2mw5kmh9bf04aqbd84c3j6a280h8-source/nixos/modules/hardware/video/webcam/ipu6.nix': null

I assume for the newer kernels the package will be not there.

@shlevy
Copy link
Member

shlevy commented Sep 1, 2024

Still trying to figure out the issue, but this is an improvement on the status quo (the driver is already in the newer kernels). Merging.

@shlevy shlevy merged commit fbbd932 into release-24.05 Sep 1, 2024
17 checks passed
@shlevy shlevy deleted the backport-331747-to-release-24.05 branch September 1, 2024 10:34
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: clean-up 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants