Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gpodder: package with support for the youtube-dl extension #331593

Merged
merged 1 commit into from
Dec 22, 2024

Conversation

uninsane
Copy link
Contributor

@uninsane uninsane commented Aug 1, 2024

gpodder ships support for subscribing to youtube feeds, leveraging youtube-dl (or yt-dlp) for downloading items. enable this from hamburger menu > extensions > youtube-dl.

see: https://gpodder.github.io/docs/extensions/youtubedl.html

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 29, 2024
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 9, 2024
@uninsane uninsane removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 22, 2024
gpodder ships support for subscribing to youtube feeds,
leveraging `youtube-dl` (or yt-dlp) for downloading items.
enable this from hamburger menu > extensions > youtube-dl.

see: <https://gpodder.github.io/docs/extensions/youtubedl.html>
@misuzu misuzu merged commit b1e0f3e into NixOS:master Dec 22, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants