python3Packages.triton*: 2.1.0 -> 3.0.0 #328247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DerDennisOP
force-pushed
the
openai-triton
branch
from
ce919e1 to
cad33ef
Compare
DerDennisOP
changed the title
ofborg
bot
added
11.by: package-maintainer
DerDennisOP
force-pushed
the
openai-triton
branch
from
cad33ef to
b4a42b8
Compare
SuperSandro2000
force-pushed
the
openai-triton
branch
3 times, most recently
from
0027083 to
b26abef
Compare
ofborg
bot
added
8.has: clean-up
8.has: package (new)
DerDennisOP
added
8.has: package (update)
13 tasks
There was a problem hiding this comment.
Oh I noticed there's a huge pile of flags in triton-llvm that can almost surely be removed, e.g. those already set by the cmake hook. Maybe in a separate PR
|
@DerDennisOP my pure (ccache-less) rebuild is almost done, now running the pytest suite; do you have any pending changes or should we rebase and force-push? |
|
|
@GaetanLepage this must be something on master, maybe after the staging merge? |
no changes, rebase and force-push pls |
SomeoneSerge
force-pushed
the
openai-triton
branch
from
842b3c0 to
6b2aa52
Compare
SomeoneSerge
force-pushed
the
openai-triton
branch
from
6b2aa52 to
2aa951f
Compare
|
I rebased on master locally but I still can't reproduce the x86_64 failure that Gaetan and Ofborg are seeing 🙃 @DerDennisOP so I guess let's append on top of 2aa951f from this point on |
|
Building Ensure to properly rebase this so that we are not fooling ourselves regarding whether it builds or not. |
|
I reproduced the failure, ignore my last night's comments. |
|
@SomeoneSerge are there big modifications to triton 3.1.x, or can we update the version without making big code modifications? |
I haven't compared, but I'd rather 3.0.x -> 3.1.x were a separate PR. If you like maybe you could already start one |
|
tbh, we are just about to finish this one, after a lot of depression and the fight against cuda, i don't really feel like starting the story all over again. A smart person once said: "Never touch a running system." |
|
Time to rip this bandaid off, what breaks shall break |
fine ... maybe next week. |
|
Opened #349159 |
This was referenced Oct 17, 2024
|
@DerDennisOP @SomeoneSerge thank you guys, your contribution was very useful |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
fixes pyTorch (torch.compile and ROCm)
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.