Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ibus-engines.pinyin: init at 1.5.1 #319049

Merged
merged 2 commits into from
Jul 3, 2024
Merged

ibus-engines.pinyin: init at 1.5.1 #319049

merged 2 commits into from
Jul 3, 2024

Conversation

azuwis
Copy link
Contributor

@azuwis azuwis commented Jun 11, 2024

Description of changes

The PinYin engine for IBus
Homepage: https://github.com/ibus/ibus-pinyin

For systems that still use the old ibus-pinyin, like Steam, see Jovian-Experiments/Jovian-NixOS#364

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jun 11, 2024
@azuwis azuwis requested a review from infinisil as a code owner June 12, 2024 09:41
@github-actions github-actions bot added 6.topic: flakes The experimental Nix feature 6.topic: lib The Nixpkgs function library labels Jun 12, 2024
@azuwis azuwis marked this pull request as draft June 12, 2024 10:10
@github-actions github-actions bot removed 6.topic: flakes The experimental Nix feature 6.topic: lib The Nixpkgs function library labels Jun 12, 2024
@azuwis azuwis marked this pull request as ready for review June 12, 2024 10:17
SuperSandro2000
SuperSandro2000 approved these changes Jun 12, 2024
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jun 14, 2024
@azuwis
Copy link
Contributor Author

azuwis commented Jul 3, 2024

@wegank Anything left for this PR to be merged?

@wegank wegank merged commit 4c2e57d into NixOS:master Jul 3, 2024
25 checks passed
@azuwis azuwis deleted the ibus-pinyin branch October 21, 2024 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@azuwis @SuperSandro2000 @wegank