Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

heynote: init at 1.6.0 #287071

Closed
wants to merge 1 commit into from
Closed

heynote: init at 1.6.0 #287071

wants to merge 1 commit into from

Conversation

Ligthiago
Copy link
Member

@Ligthiago Ligthiago commented Feb 7, 2024

Description of changes

New package: heynote
fixes #277545

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

pkgs/by-name/he/heynote/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/he/heynote/package.nix Outdated Show resolved Hide resolved
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Feb 7, 2024
@Ligthiago Ligthiago force-pushed the heynote branch 5 times, most recently from 982a013 to 97a6b5d Compare February 8, 2024 00:13
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please set meta.sourceProvenance.

pkgs/by-name/he/heynote/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/he/heynote/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/he/heynote/package.nix Outdated Show resolved Hide resolved
@dotlambda
Copy link
Member

Did you try building from source? If not have a look at other packages using electron-builder. It shouldn't be too hard.

Copy link
Member

@FliegendeWurst FliegendeWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds fine. Note: 1.8.0 was released

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 29, 2024
@wolfgangwalther
Copy link
Contributor

Did you try building from source? If not have a look at other packages using electron-builder. It shouldn't be too hard.

Agreed, that would be great.

@Ligthiago Ligthiago closed this Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: heynote
5 participants