Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

musl: fix broken source downloads #277158

Closed
wants to merge 1 commit into from
Closed

Conversation

zeuner
Copy link
Contributor

@zeuner zeuner commented Dec 27, 2023

Description of changes

musl fetches source files from git.alpinelinux.org using unstable links pointing to the git master. This caused two fetches to break due to upstream changes.

This PR fixes it by getting both files from the 3.8-stable branch.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@doronbehar
Copy link
Contributor

Why is this PR needed nowadays in 2024?

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jun 27, 2024

All the download links have now ids

@zeuner
Copy link
Contributor Author

zeuner commented Jun 27, 2024

Why is this PR needed nowadays in 2024?

Because ofborg currently still wants to use 22.05. See https://github.com/NixOS/ofborg/blob/released/flake.nix#L4 and NixOS/ofborg#670.

@doronbehar
Copy link
Contributor

Why is this PR needed nowadays in 2024?

Because ofborg currently still wants to use 22.05. See NixOS/ofborg@released/flake.nix#L4 and NixOS/ofborg#670.

That's not Nixpkgs' problem - they should update to a stable Nixpkgs release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants