Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "maintainer-list: drop gm6k" #275605

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

zeuner
Copy link
Contributor

@zeuner zeuner commented Dec 20, 2023

Description of changes

#275328 by @Mic92 violated community guidelines (https://github.com/NixOS/nixpkgs/blob/master/maintainers/README.md?plain=1#L45 ff.) and should be reverted ASAP to prevent further damage. Supersedes #275396.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Dec 20, 2023
@zeuner zeuner mentioned this pull request Dec 20, 2023
12 tasks
Copy link
Member

@rhendric rhendric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving aside the needlessly confrontational language¹ in the PR description, as I argued in
#275396 (comment), I think this PR should be merged while any proposed changes to whether GitHub accounts are required in maintainer-list.nix are debated, because we all know that debate could take months if not years.


¹ Seriously @zeuner, you're not doing yourself any favors by repeatedly calling out a trusted member of the community as ‘violat[ing] community guidelines’ when there are other, more generous interpretations at hand—can't you see how you're making this worse for yourself? Your feelings about how all this has gone down are understandably negative but exaggerating the actions others have taken that you don't like is not going to lead to reconciliation. If you have to blow off some steam, I strongly recommend doing it somewhere else.

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 20, 2023
@Janik-Haag
Copy link
Member

Janik-Haag commented Dec 21, 2023

I'm gonna merge this for the reasons @rhendric pointed out. But please stop writing hostile messages, it isn't just attacking the people you mention but also makes it very unpleasant to interact with you and leads to unneeded heated discussions that just wast the time of everyone involved.

@Janik-Haag Janik-Haag merged commit a5d84e4 into NixOS:master Dec 21, 2023
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants