Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

video-downloader: init at 0.12.20 #264447

Merged
merged 1 commit into from
Dec 16, 2024
Merged

video-downloader: init at 0.12.20 #264447

merged 1 commit into from
Dec 16, 2024

Conversation

FliegendeWurst
Copy link
Member

Description of changes

Simple package of https://github.com/Unrud/video-downloader.

Fixes #239832

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/): downloading works
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@FliegendeWurst FliegendeWurst mentioned this pull request Oct 30, 2023
Closed
IogaMaster
IogaMaster approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@IogaMaster IogaMaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 264447 run on x86_64-linux 1

1 package built:
  • video-downloader

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 1, 2023
@Aleksanaa
Copy link
Member

@ofborg build

@Aleksanaa
Copy link
Member

Hi, sorry for the late reply. Would you still like to work on this? 0.12.12 is out.

@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 4, 2024
@Scrumplex
Copy link
Member

Would you be willing to update this to https://github.com/Unrud/video-downloader/releases/tag/v0.12.20?

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Dec 1, 2024
@FliegendeWurst FliegendeWurst added the awaiting_changes (old Marvin label, do not use) label Dec 4, 2024
@FliegendeWurst FliegendeWurst marked this pull request as draft December 15, 2024 13:19
@FliegendeWurst FliegendeWurst removed the awaiting_changes (old Marvin label, do not use) label Dec 15, 2024
@FliegendeWurst FliegendeWurst changed the title video-downloader: init at 0.12.9 video-downloader: init at 0.12.20 Dec 15, 2024
@FliegendeWurst
Copy link
Member Author

Updated to latest version.

@FliegendeWurst FliegendeWurst marked this pull request as ready for review December 15, 2024 13:43
Aleksanaa
Aleksanaa approved these changes Dec 15, 2024
View reviewed changes
pkgs/by-name/vi/video-downloader/package.nix Outdated Show resolved Hide resolved
@Aleksanaa
Copy link
Member

image

When downloading https://youtu.be/SHSWHJBuFzM?t=2

@FliegendeWurst
Copy link
Member Author

Tested functionality this time. Only remaining "bug" is that it displays an odd "file not found" image before it downloaded the thumbnail. I think that must be fixed upstream.

@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 15, 2024
@Aleksanaa Aleksanaa merged commit 06a16e1 into NixOS:master Dec 16, 2024
42 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aleksanaa Aleksanaa Aleksanaa approved these changes

@IogaMaster IogaMaster IogaMaster approved these changes

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Package request: video-downloader
6 participants
@FliegendeWurst @Aleksanaa @Scrumplex @IogaMaster @delroth @wegank