Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rex: 1.13.4 -> 1.14.0 #218686

Merged
merged 1 commit into from
Jun 6, 2023
Merged

rex: 1.13.4 -> 1.14.0 #218686

merged 1 commit into from
Jun 6, 2023

Conversation

qbit
Copy link
Contributor

@qbit qbit commented Feb 27, 2023

  • Add new testing dependencies needed for 1.14.0.
  • Enable tests with some patches from upstream.
Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@qbit
rex: 1.13.4 -> 1.14.0
cf4dfd7 
- Add new testing dependencies needed for 1.14.0.
- Enable tests with some patches from upstream.
@tomodachi94
Copy link
Member

@qbit: Looks like version 1.14.2 has been released. This might make some of these patches unnecessary.

@qbit
Copy link
Contributor Author

qbit commented May 29, 2023

I have been waiting on a few more fixes: RexOps/Rex#1586

I think they are slated for the next release.

drupol
drupol approved these changes Jun 6, 2023
View reviewed changes
Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drupol drupol merged commit efe124d into NixOS:master Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drupol drupol drupol approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qbit @tomodachi94 @drupol