-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python311.pkgs.asynctest: disable #216168
Conversation
Not compatible with Python 3.11[1]. Upstream is dead. [1]: Martiusweb/asynctest#161
06dcf15
to
c654b6c
Compare
Currently approx. 40 modules are still using |
Yeah, that's my motivation here. Disabling it will save time figuring out why those packages are broken. |
Not all of them are broken though, e.g. because some actually don't use asynctest anymore. |
Previously we've also set such packages to |
Ahhhh didn't think of that. Yeah, makes sense. 40 isn't too many to go through I suppose. |
Upstream tracking:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM fairly simple but complete change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase.
Disabled in 10c3f73 |
Description of changes
Not compatible with Python 3.11.
Upstream is dead.
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)