Skip to content

Commit

Permalink
docs: remove outdated references to CODEOWNERS (#369505)
Browse files Browse the repository at this point in the history
  • Loading branch information
infinisil authored Dec 30, 2024
2 parents 75cdbb7 + bd98340 commit 7ed1504
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion maintainers/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ for the maintainers to provide feedback.

For critical packages, this convention needs to be negotiated with the
maintainer. A critical package is one that causes mass-rebuild, or where an
author is listed in the [`CODEOWNERS`](../.github/CODEOWNERS) file.
author is listed in the [`OWNERS`](../ci/OWNERS) file.

In case of critical security updates, the [security team](https://nixos.org/community/teams/security) might override these
heuristics in order to get the fixes in as fast as possible.
Expand Down
2 changes: 1 addition & 1 deletion nixos/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ Module updates are submissions changing modules in some ways. These often contai
Reviewing process:

- Ensure that the module maintainers are notified.
- [CODEOWNERS](https://help.github.com/articles/about-codeowners/) will make GitHub notify users based on the submitted changes, but it can happen that it misses some of the package maintainers.
- The continuous integration system will make GitHub notify users based on the submitted changes, but it can happen that it misses some of the package maintainers.
- Ensure that the module tests, if any, are succeeding.
- You may invoke OfBorg with `@ofborg test <module>` to build `nixosTests.<module>`
- Ensure that the introduced options are correct.
Expand Down
2 changes: 1 addition & 1 deletion pkgs/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -914,7 +914,7 @@ Reviewing process:
- Ensure that the package versioning [fits the guidelines](#versioning).
- Ensure that the commit text [fits the guidelines](../CONTRIBUTING.md#commit-conventions).
- Ensure that the package maintainers are notified.
- [CODEOWNERS](https://help.github.com/articles/about-codeowners) will make GitHub notify users based on the submitted changes, but it can happen that it misses some of the package maintainers.
- The continuous integration system will make GitHub notify users based on the submitted changes, but it can happen that it misses some of the package maintainers.
- Ensure that the meta field information [fits the guidelines](#meta-attributes) and is correct:
- License can change with version updates, so it should be checked to match the upstream license.
- If the package has no maintainer, a maintainer must be set. This can be the update submitter or a community member that accepts to take maintainership of the package.
Expand Down
2 changes: 1 addition & 1 deletion pkgs/development/haskell-modules/HACKING.md
Original file line number Diff line number Diff line change
Expand Up @@ -351,5 +351,5 @@ Here are some additional tips that didn't fit in above.
and work the new member into the `haskell-updates` rotation.

1. Optionally, have the new member add themselves to the Haskell
section in [`CODEOWNERS`](../../../.github/CODEOWNERS). This
section in [`OWNERS`](../../../ci/OWNERS). This
will cause them to get pinged on most Haskell-related PRs.

0 comments on commit 7ed1504

Please sign in to comment.