Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

processGraph(): Don't throw ThreadPoolShutDown if there is an exception (backport #12294) #12308

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 20, 2025

Motivation

Fixes

$ nix copy --derivation --to /tmp/nix /nix/store/...
error: cannot enqueue a work item while the thread pool is shutting down

The ThreadPoolShutDown exception was hiding the reason for the thread pool shut down, e.g.

error: cannot add path '/nix/store/03sl46khd8gmjpsad7223m32ma965vy9-fix-static.patch' because it lacks a signature by a trusted key

Context


Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.


This is an automatic backport of pull request #12294 done by [Mergify](https://mergify.com).

Fixes

  $ nix copy --derivation --to /tmp/nix /nix/store/...
  error: cannot enqueue a work item while the thread pool is shutting down

The ThreadPoolShutDown exception was hiding the reason for the thread
pool shut down, e.g.

  error: cannot add path '/nix/store/03sl46khd8gmjpsad7223m32ma965vy9-fix-static.patch' because it lacks a signature by a trusted key

(cherry picked from commit a8c69cc)
@mergify mergify bot requested a review from edolstra as a code owner January 20, 2025 15:24
@mergify mergify bot added the merge-queue label Jan 20, 2025
@edolstra edolstra enabled auto-merge January 20, 2025 15:27
@edolstra edolstra merged commit 8e87c19 into 2.25-maintenance Jan 20, 2025
21 checks passed
@edolstra edolstra deleted the mergify/bp/2.25-maintenance/pr-12294 branch January 20, 2025 16:19
@roberth roberth added the automatic backport This PR is a backport produced by automation (does not trigger backporting) label Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automatic backport This PR is a backport produced by automation (does not trigger backporting) merge-queue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants