Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Wait for network *online* and multi-user targets #12302

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

roberth
Copy link
Member

@roberth roberth commented Jan 20, 2025

This should help prevent some test stalls.

By default, multi-user.target does not imply that the network is fully up.

Motivation

Make the tests more robust.

Context

Relevant log lines, lots of omissions, but in order:

remote # [   15.628032] sshd-session[872]: Accepted publickey for root from 2001:db8:1::1 port 56514 ssh2: ED25519 SHA256:4ogA6akWufoJq7wuED/32LiLaVjB3+cw9gkbZ3/ugFk
remote # [   15.661248] sshd-session[872]: pam_unix(sshd:session): session opened for user root(uid=0) by (uid=0)
remote # [   16.800083] systemd[1]: Started Session 1 of User root.
remote # [   17.051388] sshd-session[892]: Received disconnect from 2001:db8:1::1 port 56514:11: disconnected by user
remote # [   17.067639] systemd-logind[703]: Session 1 logged out. Waiting for processes to exit.
client # [   18.222952] systemd[1]: Started DHCP Client.
client # [   18.232062] systemd[1]: Reached target Network is Online.
client # [   18.234925] systemd[1]: Reached target Multi-User System.
remote # [ 2489.293345] <irrelevant message, but note the timestamp>
timeout reached; test terminating...

Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

This should help prevent some test stalls.

By default, multi-user.target does not imply that the network is fully up.
@roberth roberth added the tests label Jan 20, 2025
@roberth roberth requested a review from edolstra as a code owner January 20, 2025 14:58
@edolstra edolstra enabled auto-merge January 20, 2025 15:08
@edolstra edolstra merged commit 4adb579 into master Jan 20, 2025
21 checks passed
@edolstra edolstra deleted the nixos-tests-network branch January 20, 2025 15:28
@roberth roberth added backport 2.24-maintenance Automatically creates a PR against the branch backport 2.25-maintenance Automatically creates a PR against the branch backports created Does not require attention and can be filtered away labels Jan 20, 2025
edolstra added a commit that referenced this pull request Jan 20, 2025
…2302

tests: Wait for network *online* and multi-user targets (backport #12302)
edolstra added a commit that referenced this pull request Jan 20, 2025
…2302

tests: Wait for network *online* and multi-user targets (backport #12302)
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2024-01-20-nix-team-meeting-minutes-209/59119/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.24-maintenance Automatically creates a PR against the branch backport 2.25-maintenance Automatically creates a PR against the branch backports created Does not require attention and can be filtered away tests
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants