addMultipleToStore(): Move pathsToCopy #12296
Merged
+10
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows RemoteStore::addMultipleToStore() to free the Source objects early (and in particular the associated sinkToSource() buffers). This should fix NixOS#7359. For example, memory consumption of nix copy --derivation --to ssh-ng://localhost?remote-store=/tmp/nix --derivation --no-check-sigs \ /nix/store/4p9xmfgnvclqpii8pxqcwcvl9bxqy2xf-nixos-system-...drv went from 353 MB to 74 MB.
github-actions
bot
added
the
store
roberth
approved these changes
Jan 20, 2025
Co-authored-by: Robert Hensing <[email protected]>
edolstra
added
backport 2.24-maintenance
This was referenced Jan 20, 2025
edolstra
added a commit
that referenced
this pull request
Jan 20, 2025
…2296 addMultipleToStore(): Move pathsToCopy (backport #12296)
edolstra
added a commit
that referenced
this pull request
Jan 20, 2025
…2296 addMultipleToStore(): Move pathsToCopy (backport #12296)
roberth
added
automatic backport
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2024-01-20-nix-team-meeting-minutes-209/59119/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This allows
RemoteStore::addMultipleToStore()to free theSourceobjects early (and in particular the associatedsinkToSource()buffers). This should fix #7359. For example, memory consumption ofwent from 353 MB to 74 MB.
This fix is an alternative to (or in addition to) #12255.
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.