Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reuse devmode utility from nixos/nixpkgs manuals #788

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alejandrosame
Copy link
Member

While figuring out the best name to export the nixos/nixpkgs manuals utility for out-of-tree usage, the contents of https://github.com/NixOS/nixpkgs/blob/8f6ee3a6da7025c06936fdfbdfb7ba423c3ce5d5/pkgs/tools/nix/web-devmode.nix are pasted into the overlay.

Closes #787.

While figuring out the best name to export the nixos/nixpkgs manuals utility for out-of-tree usage, the contents of
https://github.com/NixOS/nixpkgs/blob/8f6ee3a6da7025c06936fdfbdfb7ba423c3ce5d5/pkgs/tools/nix/web-devmode.nix
are pasted into the overlay.
@alejandrosame alejandrosame requested a review from a team as a code owner November 3, 2023 14:46
Copy link
Contributor

github-actions bot commented Nov 3, 2023

Deploy Preview

Name Result
Last commit: 90ef6459aff07cd8d7e3e6e3e74968ffb10bb2dc
Preview URL: https://f777e78a.nix-dot-dev.pages.dev

@alejandrosame
Copy link
Member Author

If NixOS/nixpkgs#265259 gets merged, we could pull it directly from the future 23.11 release.

@infinisil
Copy link
Member

See NixOS/nixpkgs#265259 (comment), we can use callPackage to avoid the duplication.

@fricklerhandwerk fricklerhandwerk marked this pull request as draft November 30, 2023 15:55
@fricklerhandwerk
Copy link
Collaborator

fricklerhandwerk commented Nov 30, 2023

Discussed in the docs meeting:

  • Put into draft mode until it's fixed up.
  • Would be good to have a note why this is better than the Python live reload thing that's already there.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2023-11-30-documentation-team-meeting-notes-97/36271/1

@fricklerhandwerk
Copy link
Collaborator

With NixOS/nixpkgs#354556 merged we can use devmode directly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New devmode hides build errors
4 participants