Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation warning with TripleDES #589

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Conversation

sosthene-nitrokey
Copy link
Contributor

This PR fixes the import for the TripleDES cipher from cryptography to use the new path, instead of the deprecated one that will be removed in a future releases

Changes

- No user facing change

Checklist

Make sure to run make check and make fix before creating a PR, otherwise the CI will fail.

  • tested with Python3.9
  • signed commits
  • updated documentation (e.g. parameter description, inline doc, docs.nitrokey)
  • added labels

Test Environment and Execution

  • OS: Arch
  • device's model: NK3AN
  • device's firmware version: 1.8.0-rc.1

Relevant Output Example

Fixes #588

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
@sosthene-nitrokey sosthene-nitrokey merged commit dbc6e7d into master Nov 28, 2024
8 checks passed
@sosthene-nitrokey sosthene-nitrokey deleted the fix-tdes-hazmat branch November 28, 2024 10:34
@robin-nitrokey
Copy link
Member

This change is incompatible with older cryptography versions as the decrepit module was introduced in v43.0.0. We currently depend on "cryptography >=41.0.4,<44".

robin-nitrokey added a commit that referenced this pull request Dec 8, 2024

Verified

This commit was signed with the committer’s verified signature.
robin-nitrokey Robin Krahl
This patch updates the minimum cryptography dependency version to v43 as
required by #589.  As v44
seems to work well too, we can also bump the upper limit.
robin-nitrokey added a commit that referenced this pull request Dec 15, 2024

Verified

This commit was signed with the committer’s verified signature.
robin-nitrokey Robin Krahl
This patch updates the minimum cryptography dependency version to v43 as
required by #589.  As v44
seems to work well too, we can also bump the upper limit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TripleDES was moved to the hazmat module
3 participants