nk3/update: add pre_bootloader_hint for update process #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
pre_bootloader_hintinto the updating ABC. This should allow to hook into the process especially for situations like Nitrokey/nitrokey-app2#254 to improve the update process in e.g. QubesOSChanges
pre_bootloader_hintas hook during updatepre_bootloader_hintfor cli-based update processChecklist
Make sure to run
make checkandmake fixbefore creating a PR, otherwise the CI will fail.Test Environment and Execution