Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NetHSM CLI command options and messages #204

Merged
merged 8 commits into from
Nov 28, 2023

Conversation

mmerklinger
Copy link
Collaborator

This PR adjusts the documentation to recent changes in the pynitrokey NetHSM CLI.

PRs with the respective changes are:

@mmerklinger mmerklinger self-assigned this Nov 28, 2023
@jans23
Copy link
Member

jans23 commented Nov 28, 2023

Are the warnings in the code blocks sufficient or should we add an additional warning box?

@mmerklinger mmerklinger marked this pull request as ready for review November 28, 2023 13:36
@mmerklinger
Copy link
Collaborator Author

I added the warnings also in a warning box below the explanation of the command. Similar like with all the other warning boxes.

@mmerklinger mmerklinger merged commit 0be7eb6 into master Nov 28, 2023
@mmerklinger mmerklinger deleted the nethsm-messages-update branch November 28, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants