Copy to clipboard #157
Copy to clipboard #157
Conversation
jj-so
requested review from
robin-nitrokey,
daringer,
mmerklinger and
Niklap97
There was a problem hiding this comment.
Does it really make sense to clear the clipboard if the OTP times out? Most implementations will still accept the OTP for at least one time window after it expired. So being able to paste the OTP after it expired improves usability. Also, contrary to passwords, accidentally pasting an OTP somewhere it does not belong does not do much harm, so I think there is no strong need for clearing it. What do you think?
|
Jip, would also second your thought @robin-nitrokey - generally an OTP is not a secret and can stay forever in the clipboard - once we do this for passwords the story is different I would say - so we need this functionality anyways, I would just not apply it in this very case here. |
|
perfect! lgtm! |
add Copy to Clipboard
modified: nitrokeyapp/secrets_tab/__init__.py
remove clear the clipboard
modified: nitrokeyapp/secrets_tab/__init__.py
squash 890773f add Copy to Clipboard modified: nitrokeyapp/secrets_tab/__init__.py
squash 015ec44 remove clear the clipboard modified: nitrokeyapp/secrets_tab/__init__.py
modified: nitrokeyapp/secrets_tab/__init__.py
modified: nitrokeyapp/ui/secrets_tab.ui
jj-so
force-pushed
the
copyToClipboard
branch
from
015ec44 to
fc41126
Compare
add COPY TO CLIPBOARD Button for ONE TIME PASSWORD