Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CTAP2 test suite #29

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add CTAP2 test suite #29

wants to merge 1 commit into from

Conversation

robin-nitrokey
Copy link
Member

This patch adds the CTAP2-test-tool test suite from https://github.com/google/CTAP2-test-tool. To make it easier to follow the test execution and to identify problematic test cases, each test case from CTAP2-test-tool is mapped to a test case in our test suite. This adds significant overhead though because the test environment has to be setup separately for each test case.

Limitations:

  • Requires Fix CTAP2 tests nitrokey-3-firmware#311
  • Sometimes, it takes several attempts to attach the usbip device. In some cases, this means that the reset time window is expired once the test suite tries to perform a reset after a reboot. We could try to restart the binary after every failed attach to work around this issue.

This patch adds the CTAP2-test-tool test suite from
https://github.com/google/CTAP2-test-tool.  To make it easier to follow
the test execution and to identify problematic test cases, each test
case from CTAP2-test-tool is mapped to a test case in our test suite.
This adds significant overhead though because the test environment has
to be setup separately for each test case.
@sosthene-nitrokey
Copy link
Collaborator

Sometimes, it takes several attempts to attach the usbip device. In some cases, this means that the reset time window is expired once the test suite tries to perform a reset after a reboot. We could try to restart the binary after every failed attach to work around this issue.

But since attaching needs multiple attempts each time wouldn't that just loop infinitely?

@robin-nitrokey
Copy link
Member Author

But since attaching needs multiple attempts each time wouldn't that just loop infinitely?

I would consider two calls to usbip attach as one attempt, which works at least 9 out of 10 times for me. So the chances should be pretty high that it works after two attempts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants