Fix usbip runner build #583
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only building catches potential linker errors or failing assertions in const contexts.
Some mechanisms are only implemented by the SE050 backend and not available in the usbip runner. Instead of failing the compilation, this patch ignores those mechanisms when compiling the usbip runner so that a runtime error is raised when such a mechanism is used. In the medium term, we should use a backend providing a software implementation of these mechanisms.
|
No significant changes. Insignifcant changes
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes sure that the usbip runner is always built in the CI so that linker errors and failed const assertions are properly detected. Currently, the build fails as some mechanisms are only implemented by the SE050 backend and are not available in the usbip runner. Instead of failing the compilation, this PR ignores those mechanisms when compiling the usbip runner so that a runtime error is raised when such a mechanism is used. In the medium term, we should use a backend providing a software implementation of these mechanisms.