Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Convert from Mockito to Mockk and Assertj to assertk #460

Merged
merged 5 commits into from
Dec 17, 2024

Conversation

kingargyle
Copy link
Contributor

This will update the kotlin tests to use mockk and assertk. All tests will eventually be updated.

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 38.99%. Comparing base (2aef511) to head (9e4c601).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...lds/serenity/ui/video/player/ExoplayerPresenter.kt 57.14% 6 Missing ⚠️
...lds/serenity/ui/video/player/PlaybackRepository.kt 66.66% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #460      +/-   ##
=============================================
+ Coverage      38.86%   38.99%   +0.12%     
- Complexity       272      273       +1     
=============================================
  Files             37       37              
  Lines           1572     1590      +18     
  Branches         156      157       +1     
=============================================
+ Hits             611      620       +9     
- Misses           926      932       +6     
- Partials          35       38       +3     
Flag Coverage Δ
unittests 38.99% <62.50%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kingargyle kingargyle merged commit c1a1173 into develop Dec 17, 2024
4 checks passed
@kingargyle kingargyle deleted the dac_mockk_unittests branch December 17, 2024 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant