Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent ConcurrentModificationException #140

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

prevent ConcurrentModificationException #140

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b49e6de
use synchronized List for timestampedAnnotations List to prevent Conc…
azplanlos Nov 28, 2022
6a1751a
use CopyOnWriteArrayList for timestampedAnnotations List to prevent C…
azplanlos Nov 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion wingtips-core/src/main/java/com/nike/wingtips/Span.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
import java.util.List;
import java.util.Map;
import java.util.Objects;
import java.util.concurrent.CopyOnWriteArrayList;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.atomic.AtomicBoolean;

Expand Down Expand Up @@ -71,7 +72,7 @@ public class Span implements Closeable, Serializable {
private final Map<String,String> tags = new LinkedHashMap<>();
private final Map<String,String> unmodifiableTags = Collections.unmodifiableMap(tags);
// The default initial capacity (10) seems ok for the annotations list.
private final List<TimestampedAnnotation> annotations = new ArrayList<>();
private final List<TimestampedAnnotation> annotations = new CopyOnWriteArrayList<>();
private final List<TimestampedAnnotation> unmodifiableAnnotations = Collections.unmodifiableList(annotations);

private Long durationNanos;
Expand Down