feat: support arbitrary delimiters in acc-role profile names #475
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the cred_profile configuration parameter has the form "accXrole" for any character X, it is treated as "acc-role" with X as the delimiter between account and role in the generated profile name.
Related Issue
#474
Motivation and Context
See the issue.
How Has This Been Tested?
Added two new tests, one with a colon and resolve_alias true, the other with a slash and resolve_alias false.
Screenshots (if appropriate):
Types of changes
Technically will break if anyone is using a literal profile name that fits the pattern, e.g. 'acc@role'
Checklist: