Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] issue 194: Uncaught exception IndexError when calling get_project_parameter #197

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[fix] issue 194: Uncaught exception IndexError when calling get_project_parameter #197

wants to merge 1 commit into from

Conversation

menathan
Copy link

@menathan menathan commented Jan 14, 2025 •
edited
Loading

Description

Catching IndexError exception in context's get_project_parameter function.

Related Issue

Fixes #194

Motivation and Context

See #194

How Has This Been Tested?

Added a new unit test to cover scenario when no ENV variable BRICKFLOW_PROJECT_PARAMS is provided.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

pariksheet
pariksheet approved these changes Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@pariksheet pariksheet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pariksheet pariksheet pariksheet approved these changes

@asingamaneni asingamaneni Awaiting requested review from asingamaneni asingamaneni is a code owner

@stikkireddy stikkireddy Awaiting requested review from stikkireddy stikkireddy is a code owner

@newfront newfront Awaiting requested review from newfront newfront is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Uncaught exception "IndexError" when calling get_project_parameter
2 participants
@menathan @pariksheet