Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change NTP server #4

Merged
merged 2 commits into from
Oct 5, 2023
Merged

Change NTP server #4

merged 2 commits into from
Oct 5, 2023

Conversation

V10lator
Copy link
Contributor

This changes the NTP server to the pool from https://www.ntppool.org/zone

Having a config file to allow the user to set it or something would ofc. be even better. :)

Signed-off-by: Thomas Rohloff <[email protected]>
@Nightkingale
Copy link
Owner

I think you're right. Instead of changing the server outright, I'd prefer if we make it part of the config, either as a separate file, or through the WUPS configuration. This way, we could allow people to decide which NTP server they'd like to use.

@Nightkingale Nightkingale added the enhancement New feature or request label Jun 23, 2023
@Nightkingale
Copy link
Owner

This should not have been closed, so I apologize for that. In the near future, I would like to add the ability to specify a custom server (while still using time.windows.com as the default). I will be experimenting with this idea whenever I get the chance to.

@Nightkingale Nightkingale reopened this Sep 23, 2023
@Nightkingale Nightkingale merged commit 26d6742 into Nightkingale:master Oct 5, 2023
1 check passed
@Nightkingale
Copy link
Owner

Nightkingale commented Oct 5, 2023

I have done a lot of thinking on this over the past few days, since my passion for maintaining this project kicked back in. I'm deciding to change the default server to pool.ntp.org, primarily because it seems much friendlier for an open source project like this, compared to what I was using before.

In the future, I will look into making this changeable through editing the config file. Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants