Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backported Time-Sync into upstream #22

Merged
merged 14 commits into from
May 31, 2024

Conversation

dkosmari
Copy link
Collaborator

@dkosmari dkosmari commented May 30, 2024

I didn't touch the README.md nor the version in Makefile. Remember to modify them later, as well as any item name (in cfg.cpp) and item ordering (in config_screen.cpp) changes.

UI changes:

  • Pressing X on a config item resets it back to the actual default value, not to the previous value.
  • Configuration items now support holding the button down for repeated events.
  • Timezone offset is now set trough a single item, in a more natural format.
  • The preview clock is now updated in real time while it's focused, thanks to the new WUPS API.
  • Some tweaks to config items, like better text scrolling, and boolean items can always be toggled with left/right.

New features:

  • Timezone offset/DST can be updated automatically (through a HTTP query to ip-api) when the plugin runs.
  • Number of background threads can be configured. This controls how many NTP servers are queried at the same time.
  • More control over notification verbosity: it's now possible to have a non-verbose level of notifications, that only reports when the clock is adjusted, or if total failure (no NTP server could be used) happened. Users that need troubleshooting NTP/network problems can enable the "verbose" mode to see more details.
  • Opening the config menu reloads the settings from the JSON file. This makes it more convenient to edit the file through FTP, when the user wants to use a custom NTP server.

Daniel K. O. (dkosmari) added 14 commits October 6, 2023 22:38
--HG--
branch : upstream
--HG--
branch : upstream
--HG--
branch : upstream
--HG--
branch : upstream
--HG--
branch : upstream
--HG--
branch : upstream
--HG--
branch : upstream
--HG--
branch : upstream
--HG--
branch : upstream
--HG--
branch : upstream
--HG--
branch : upstream
--HG--
branch : upstream
--HG--
branch : upstream
@Nightkingale
Copy link
Owner

As always, thank you for your contributions! It is greatly appreciated, and helps make this plugin the best it can be!

@Nightkingale Nightkingale merged commit a603478 into Nightkingale:master May 31, 2024
1 check passed
@Nightkingale Nightkingale added the enhancement New feature or request label Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants